Skip to content

Conversation

@sh1man999
Copy link

No description provided.

Copy link
Collaborator

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a lot of code duplication, please inherit the base class of BatchedInferencePipeline and modify the needed functions only, also do not use asyncio.to_thread

@Purfview
Copy link
Contributor

Please keep the comments in English (there are multiple comments in Russian).

@sh1man999
Copy link
Author

This introduces a lot of code duplication, please inherit the base class of BatchedInferencePipeline and modify the needed functions only, also do not use asyncio.to_thread

what other test is needed. I have already added the test_async_batched_transcribe test

@Scott-Hickmann-Sanas
Copy link

Why was this not merged? This would be a very helpful addition to this library.

@MahmoudAshraf97
Copy link
Collaborator

It's indeed a very helpful addition, but this is a very low quality PR for such an important feature, I'm willing to accept contributions if someone is willing to put enough effort in it and not just slap a bunch of AI authored commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants